Update async-channel/async-std #5889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively trivial PR, just updated
async-channelto new major version and tried to get rid of old version by updatingasync-std, though it didn't help and there are other dependencies still relying on old version ofasync-channelhere upstream, but downstream users will be able to remove it in some cases, which is already a good thing.The biggest change in new major version of
async-channelis that it no longer implementsUnpin, so had to doPin<Box<T>>in a few places.Not sure if this needs prdoc since changes are trivial and mostly internal.